feat: implement aggregation methods with support for grouping and med…#577
Open
feat: implement aggregation methods with support for grouping and med…#577
Conversation
…ian calculations in Clickhouse, MongoDB, and MySQL connectors
Contributor
There was a problem hiding this comment.
Pull request overview
Adds getAggregateWithOriginalTypes support to additional data connectors so resource().aggregate() can run server-side aggregations (sum/count/avg/min/max/median) with optional grouping by field or date truncation.
Changes:
- Implemented aggregation query building + grouping for MySQL, MongoDB, and ClickHouse connectors.
- Added connector-specific median implementations (ClickHouse quantile-based; MySQL/Mongo compute median in application code).
- Updated ClickHouse connector typing for
getDataWithOriginalTypesreturn type.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
adminforth/dataConnectors/mysql.ts |
Adds aggregate query generation with grouping and a JS-computed median fed by GROUP_CONCAT. |
adminforth/dataConnectors/mongo.ts |
Adds MongoDB aggregation pipeline for group + aggregates, including JS-side median from $pushed values. |
adminforth/dataConnectors/clickhouse.ts |
Adds ClickHouse aggregate query generation with grouping and median via quantile(0.5). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ian calculations in Clickhouse, MongoDB, and MySQL connectors
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… return types and improve date truncation handling
…on variable for group_concat_max_len
…nctions and improve performance
…endpoints for car statistics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ian calculations in Clickhouse, MongoDB, and MySQL connectors